Bug 138306

Summary: 'noreturn' function does return warning in LLVMOverrides.cpp
Product: WebKit Reporter: Akos Kiss <akiss>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, fpizlo, oliver, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch.
none
Proposed patch, v2 none

Description Akos Kiss 2014-11-03 04:02:03 PST 
When building with FTL JIT enabled (on x86_64/Linux), gcc is emitting the following warning:

[71/651] Building CXX object Source/JavaScriptCore/CMakeFiles/llvmForJSC.dir/llvm/library/LLVMOverrides.cpp.o
../../Source/JavaScriptCore/llvm/library/LLVMOverrides.cpp: In function ‘void abort()’:
../../Source/JavaScriptCore/llvm/library/LLVMOverrides.cpp:57:1: warning: ‘noreturn’ function does return [enabled by default]
 }
 ^

No big issue, but it would be better to get rid of it.
Comment 1 Akos Kiss 2014-11-03 04:04:37 PST 
Created attachment 240839 [details]
Proposed patch.

No regressions on x86_64/Linux/GTK
Comment 2 Akos Kiss 2014-11-03 04:44:38 PST 
Created attachment 240840 [details]
Proposed patch, v2

Mac seems to be more rigorous. Adding more NO_RETURNs.
Comment 3 WebKit Commit Bot 2014-11-10 00:00:40 PST 
Comment on attachment 240840 [details]
Proposed patch, v2

Clearing flags on attachment: 240840

Committed r175802: <http://trac.webkit.org/changeset/175802>
Comment 4 WebKit Commit Bot 2014-11-10 00:00:44 PST 
All reviewed patches have been landed.  Closing bug.