Bug 138301

Summary: [EFL] Remove dependency of PageViewportController from PageViewportControllerClient
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lucas.de.marchi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ryuan Choi
Reported 2014-11-03 00:14:43 PST
PageViewportControllerClient does not need to keep the instance of PageViewportController.
Attachments
Patch (12.08 KB, patch)
2014-11-03 00:20 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2014-11-03 00:20:29 PST
Created attachment 240832 [details] Patch
Gyuyoung Kim
Comment 2 2014-11-03 00:29:34 PST
Comment on attachment 240832 [details] Patch LGTM. PageViewportControllerClientEfl already had a member variable of EwkView which has a member variable of PageViewportController. r=me. BTW, I don't think EwkView doesn't need to has m_pageViewportControllerClient as member variable. Because it is only needed by PageViewportController.
Ryuan Choi
Comment 3 2014-11-03 02:50:04 PST
(In reply to comment #2) > Comment on attachment 240832 [details] > Patch > > LGTM. PageViewportControllerClientEfl already had a member variable of > EwkView which has a member variable of PageViewportController. r=me. > > BTW, I don't think EwkView doesn't need to has > m_pageViewportControllerClient as member variable. Because it is only needed > by PageViewportController. I think that PageViewportController takes the commond logic while PageViewportControllerClient takes port specific logic as callback style of PageViewportController. Anyway, I also agree that PageViewportControllerClientEfl can be merged into EwkView as not a member but also a interface. If you aree, I will make it in different bug.
WebKit Commit Bot
Comment 4 2014-11-03 03:26:45 PST
Comment on attachment 240832 [details] Patch Clearing flags on attachment: 240832 Committed r175468: <http://trac.webkit.org/changeset/175468>
WebKit Commit Bot
Comment 5 2014-11-03 03:26:50 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.