| Summary: | [EFL] Remove dependency of PageViewportController from PageViewportControllerClient | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryuan Choi <ryuan.choi> | ||||
| Component: | WebKit EFL | Assignee: | Ryuan Choi <ryuan.choi> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, lucas.de.marchi | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Ryuan Choi
2014-11-03 00:14:43 PST
Created attachment 240832 [details]
Patch
Comment on attachment 240832 [details]
Patch
LGTM. PageViewportControllerClientEfl already had a member variable of EwkView which has a member variable of PageViewportController. r=me.
BTW, I don't think EwkView doesn't need to has m_pageViewportControllerClient as member variable. Because it is only needed by PageViewportController.
(In reply to comment #2) > Comment on attachment 240832 [details] > Patch > > LGTM. PageViewportControllerClientEfl already had a member variable of > EwkView which has a member variable of PageViewportController. r=me. > > BTW, I don't think EwkView doesn't need to has > m_pageViewportControllerClient as member variable. Because it is only needed > by PageViewportController. I think that PageViewportController takes the commond logic while PageViewportControllerClient takes port specific logic as callback style of PageViewportController. Anyway, I also agree that PageViewportControllerClientEfl can be merged into EwkView as not a member but also a interface. If you aree, I will make it in different bug. Comment on attachment 240832 [details] Patch Clearing flags on attachment: 240832 Committed r175468: <http://trac.webkit.org/changeset/175468> All reviewed patches have been landed. Closing bug. |