Bug 138290

Summary: Replace RenderSVGResource::cast<T>() with downcast<T>()
Product: WebKit Reporter: Zan Dobersek <zan>
Component: WebCore Misc.Assignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin, dino, d-r, esprehn+autocc, fmalita, glenn, gyuyoung.kim, kondapallykalyan, pdr, schenney, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Zan Dobersek 2014-11-02 05:41:59 PST 
Spin-off from bug #137911.
Comment 1 Zan Dobersek 2014-11-14 04:20:29 PST 
Created attachment 241578 [details]
Patch
Comment 2 Chris Dumez 2014-11-14 10:37:00 PST 
Comment on attachment 241578 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241578&action=review

r=me

> Source/WebCore/rendering/svg/RenderSVGResourceContainer.h:94
> +    RenderSVGResource* container = getRenderSVGResourceContainerById(document, id);

I don't see any compilation error if I use auto* here. Are you sure this is needed?
Comment 3 Zan Dobersek 2014-11-16 23:37:28 PST 
Comment on attachment 241578 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241578&action=review

>> Source/WebCore/rendering/svg/RenderSVGResourceContainer.h:94
>> +    RenderSVGResource* container = getRenderSVGResourceContainerById(document, id);
> 
> I don't see any compilation error if I use auto* here. Are you sure this is needed?

Yes, a compilation error is thrown when specializing RenderSVGResourceFilter type traits for both RenderObject and RenderSVGResource.
Comment 4 Zan Dobersek 2014-11-16 23:44:15 PST 
Comment on attachment 241578 [details]
Patch

Clearing flags on attachment: 241578

Committed r176180: <http://trac.webkit.org/changeset/176180>
Comment 5 Zan Dobersek 2014-11-16 23:44:28 PST 
All reviewed patches have been landed.  Closing bug.