RESOLVED FIXED 138290
Replace RenderSVGResource::cast<T>() with downcast<T>() 
https://bugs.webkit.org/show_bug.cgi?id=138290
Summary Replace RenderSVGResource::cast<T>() with downcast<T>()
Zan Dobersek
Reported 2014-11-02 05:41:59 PST
Spin-off from bug #137911.
Attachments
Patch (14.31 KB, patch)
2014-11-14 04:20 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2014-11-14 04:20:29 PST
Created attachment 241578 [details] Patch
Chris Dumez
Comment 2 2014-11-14 10:37:00 PST
Comment on attachment 241578 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241578&action=review r=me > Source/WebCore/rendering/svg/RenderSVGResourceContainer.h:94 > + RenderSVGResource* container = getRenderSVGResourceContainerById(document, id); I don't see any compilation error if I use auto* here. Are you sure this is needed?
Zan Dobersek
Comment 3 2014-11-16 23:37:28 PST
Comment on attachment 241578 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241578&action=review >> Source/WebCore/rendering/svg/RenderSVGResourceContainer.h:94 >> + RenderSVGResource* container = getRenderSVGResourceContainerById(document, id); > > I don't see any compilation error if I use auto* here. Are you sure this is needed? Yes, a compilation error is thrown when specializing RenderSVGResourceFilter type traits for both RenderObject and RenderSVGResource.
Zan Dobersek
Comment 4 2014-11-16 23:44:15 PST
Comment on attachment 241578 [details] Patch Clearing flags on attachment: 241578 Committed r176180: <http://trac.webkit.org/changeset/176180>
Zan Dobersek
Comment 5 2014-11-16 23:44:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.