Bug 138290 - Replace RenderSVGResource::cast<T>() with downcast<T>()
Summary: Replace RenderSVGResource::cast<T>() with downcast<T>()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-02 05:41 PST by Zan Dobersek
Modified: 2014-11-16 23:44 PST (History)
13 users (show)

See Also:

Attachments
Patch (14.31 KB, patch)
2014-11-14 04:20 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2014-11-02 05:41:59 PST 
Spin-off from bug #137911.
Comment 1 Zan Dobersek 2014-11-14 04:20:29 PST 
Created attachment 241578 [details]
Patch
Comment 2 Chris Dumez 2014-11-14 10:37:00 PST 
Comment on attachment 241578 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241578&action=review

r=me

> Source/WebCore/rendering/svg/RenderSVGResourceContainer.h:94
> +    RenderSVGResource* container = getRenderSVGResourceContainerById(document, id);

I don't see any compilation error if I use auto* here. Are you sure this is needed?
Comment 3 Zan Dobersek 2014-11-16 23:37:28 PST 
Comment on attachment 241578 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241578&action=review

>> Source/WebCore/rendering/svg/RenderSVGResourceContainer.h:94
>> +    RenderSVGResource* container = getRenderSVGResourceContainerById(document, id);
> 
> I don't see any compilation error if I use auto* here. Are you sure this is needed?

Yes, a compilation error is thrown when specializing RenderSVGResourceFilter type traits for both RenderObject and RenderSVGResource.
Comment 4 Zan Dobersek 2014-11-16 23:44:15 PST 
Comment on attachment 241578 [details]
Patch

Clearing flags on attachment: 241578

Committed r176180: <http://trac.webkit.org/changeset/176180>
Comment 5 Zan Dobersek 2014-11-16 23:44:28 PST 
All reviewed patches have been landed.  Closing bug.