Bug 138289

Summary:

Reduce the cost of argumentCount checks in the JS bindings

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Bindings

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ggaren, kling, rniwa, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Chris Dumez

Reported 2014-11-01 23:27:17 PDT

Reduce the cost of argumentCount checks in the JS bindings by hinting to the compiler that it is UNLIKELY that those methods are called with too few arguments.

Attachments
Patch (1.72 KB, patch) 2014-11-01 23:30 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2014-11-01 23:30:00 PDT

Created attachment 240807 [details] Patch

WebKit Commit Bot

Comment 2 2014-11-02 08:38:00 PST

Comment on attachment 240807 [details] Patch Clearing flags on attachment: 240807 Committed r175462: <http://trac.webkit.org/changeset/175462>

WebKit Commit Bot

Comment 3 2014-11-02 08:38:03 PST

All reviewed patches have been landed. Closing bug.

Simon Fraser (smfr)

Comment 4 2014-11-02 10:15:01 PST

This broke bindings tests: https://build.webkit.org/builders/Apple%20Mavericks%20Debug%20WK2%20%28Tests%29/builds/7751/steps/bindings-generation-tests/logs/stdio

Chris Dumez

Comment 5 2014-11-02 10:17:36 PST

(In reply to comment #4) > This broke bindings tests: > https://build.webkit.org/builders/ > Apple%20Mavericks%20Debug%20WK2%20%28Tests%29/builds/7751/steps/bindings- > generation-tests/logs/stdio Oh, they need to be rebaselined, I'll take care of it now, thanks.

Chris Dumez

Comment 6 2014-11-02 10:19:53 PST

Rebaselined the bindings tests in <http://trac.webkit.org/changeset/175463>.

Note You need to log in before you can comment on or make changes to this bug.