Bug 138285

Summary: Support modern range loops over CSSValueList
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, kling, koivisto, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Chris Dumez 2014-11-01 16:00:06 PDT 
We should support modern range loops over CSSValueList and kill the custom CSSValueListInspector / CSSValueListIterator classes to modernize the code a bit.
Comment 1 Chris Dumez 2014-11-01 18:10:02 PDT 
Created attachment 240798 [details]
Patch
Comment 2 WebKit Commit Bot 2014-11-01 18:11:24 PDT 
Attachment 240798 [details] did not pass style-queue:


ERROR: Source/WebCore/css/CSSToStyleMap.cpp:546:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/css/DeprecatedStyleBuilder.cpp:1571:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Chris Dumez 2014-11-01 18:35:08 PDT 
Created attachment 240800 [details]
Patch
Comment 4 WebKit Commit Bot 2014-11-01 18:37:36 PDT 
Attachment 240800 [details] did not pass style-queue:


ERROR: Source/WebCore/css/CSSToStyleMap.cpp:546:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/css/DeprecatedStyleBuilder.cpp:1571:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Chris Dumez 2014-11-03 09:08:09 PST 
Created attachment 240856 [details]
Patch
Comment 6 WebKit Commit Bot 2014-11-03 09:09:47 PST 
Attachment 240856 [details] did not pass style-queue:


ERROR: Source/WebCore/css/CSSToStyleMap.cpp:546:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/css/DeprecatedStyleBuilder.cpp:1530:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Andreas Kling 2014-11-03 12:03:03 PST 
Comment on attachment 240856 [details]
Patch

r=me
Comment 8 Chris Dumez 2014-11-03 12:25:44 PST 
Created attachment 240867 [details]
Patch
Comment 9 WebKit Commit Bot 2014-11-03 12:27:50 PST 
Attachment 240867 [details] did not pass style-queue:


ERROR: Source/WebCore/css/CSSToStyleMap.cpp:546:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/css/DeprecatedStyleBuilder.cpp:1530:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 WebKit Commit Bot 2014-11-03 12:48:18 PST 
Comment on attachment 240867 [details]
Patch

Clearing flags on attachment: 240867

Committed r175487: <http://trac.webkit.org/changeset/175487>
Comment 11 WebKit Commit Bot 2014-11-03 12:48:23 PST 
All reviewed patches have been landed.  Closing bug.
Comment 12 Chris Dumez 2014-11-03 14:20:22 PST 
Comment on attachment 240867 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240867&action=review

> Source/WebCore/css/StyleResolver.cpp:2037
> +    ASSERT(it != values.end());

arf. This should be it == values.end(), my bad. will fix now.
Comment 13 Chris Dumez 2014-11-03 14:22:40 PST 
(In reply to comment #12)
> Comment on attachment 240867 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240867&action=review
> 
> > Source/WebCore/css/StyleResolver.cpp:2037
> > +    ASSERT(it != values.end());
> 
> arf. This should be it == values.end(), my bad. will fix now.

Landed assertion fix in <http://trac.webkit.org/changeset/175490>.