| Summary: | Simple line layout: Cleanup line initialization and line closing. | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, esprehn+autocc, glenn, koivisto, kondapallykalyan, mmaxfield, ossy, rniwa | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
zalan
2014-10-31 20:07:25 PDT
The next step to abstract out text handling so that a text fragment can manage continuation (can transition from one render element to another) Created attachment 240779 [details]
Patch
Comment on attachment 240779 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240779&action=review > Source/WebCore/rendering/SimpleLineLayout.cpp:313 > + , committedLogicalRight(0) Why is this one "logical"? If we are going to support vertical text should some others be logical too? > Source/WebCore/rendering/SimpleLineLayout.cpp:314 > + , currentPosition(0) maybe just call it 'position'? Word "current" rarely adds much. Created attachment 240803 [details]
Patch
Created attachment 240805 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
(In reply to comment #3) > Comment on attachment 240779 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=240779&action=review > > > Source/WebCore/rendering/SimpleLineLayout.cpp:313 > > + , committedLogicalRight(0) > > Why is this one "logical"? If we are going to support vertical text should > some others be logical too? Done. > > > Source/WebCore/rendering/SimpleLineLayout.cpp:314 > > + , currentPosition(0) > > maybe just call it 'position'? Word "current" rarely adds much. Done. Created attachment 240808 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 240929 [details]
Patch
Comment on attachment 240929 [details] Patch Clearing flags on attachment: 240929 Committed r175565: <http://trac.webkit.org/changeset/175565> All reviewed patches have been landed. Closing bug. (In reply to comment #9) > Comment on attachment 240929 [details] > Patch > > Clearing flags on attachment: 240929 > > Committed r175565: <http://trac.webkit.org/changeset/175565> It broke the Apple Windows build, as the EWS noticed: 1>..\rendering\SimpleLineLayout.cpp(678): error C2512: 'WebCore::SimpleLineLayout::Run' : no appropriate default constructor available (In reply to comment #11) > (In reply to comment #9) > > Comment on attachment 240929 [details] > > Patch > > > > Clearing flags on attachment: 240929 > > > > Committed r175565: <http://trac.webkit.org/changeset/175565> > > It broke the Apple Windows build, as the EWS noticed: > 1>..\rendering\SimpleLineLayout.cpp(678): error C2512: > 'WebCore::SimpleLineLayout::Run' : no appropriate default constructor > available Thanks. http://trac.webkit.org/changeset/175574 |