Bug 138263

Summary:

Change the ScrollingThread code to use RunLoop::main().dispatch() rather than callOnMainThread(), which has Obj-C overhead

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, cmarcelo, commit-queue, jamesr, luiz, simon.fraser, thorton, tonikitoo

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Simon Fraser (smfr) 2014-10-31 15:20:23 PDT

Change the ScrollingThread code to use RunLoop::main().dispatch() rather than callOnMainThread(), which has Obj-C overhead

Comment 1 Simon Fraser (smfr) 2014-10-31 15:21:34 PDT

Created attachment 240759 [details]
Patch

Comment 2 Simon Fraser (smfr) 2014-10-31 15:22:09 PDT

rdar://problem/18833601

Comment 3 Geoffrey Garen 2014-10-31 15:23:56 PDT

Comment on attachment 240759 [details]
Patch

Should we change the implementation of callOnMainThread to use RunLoop::main().dispatch?

Comment 4 Simon Fraser (smfr) 2014-10-31 15:30:11 PDT

(In reply to comment #3)
> Comment on attachment 240759 [details]
> Patch
> 
> Should we change the implementation of callOnMainThread to use
> RunLoop::main().dispatch?

Probably, but the fix needs to take the iOS WebThread into account.

Comment 5 WebKit Commit Bot 2014-10-31 16:14:47 PDT

Comment on attachment 240759 [details]
Patch

Clearing flags on attachment: 240759

Committed r175433: <http://trac.webkit.org/changeset/175433>

Comment 6 WebKit Commit Bot 2014-10-31 16:14:51 PDT

All reviewed patches have been landed.  Closing bug.