Bug 138255

Summary:

Make writes to RegExpObject.lastIndex cacheable.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

JavaScriptCore

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, commit-queue, ggaren, kling

Priority:

Keywords:

Performance

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Andreas Kling 2014-10-31 11:12:49 PDT

We're not caching writes to RegExpObject.lastIndex. Let's try doing that.

Comment 1 Andreas Kling 2014-10-31 11:13:39 PDT

Created attachment 240745 [details]
Patch

Comment 2 Geoffrey Garen 2014-10-31 11:33:47 PDT

Comment on attachment 240745 [details]
Patch

IC is nice. It's probably even nicer just to make lastIndex a vanilla JS property.

Comment 3 Andreas Kling 2014-10-31 11:50:01 PDT

(In reply to comment #2)
> Comment on attachment 240745 [details]
> Patch
> 
> IC is nice. It's probably even nicer just to make lastIndex a vanilla JS
> property.

Yeah. I'll land this, but let's talk about that.

Comment 4 WebKit Commit Bot 2014-10-31 12:28:09 PDT

Comment on attachment 240745 [details]
Patch

Clearing flags on attachment: 240745

Committed r175416: <http://trac.webkit.org/changeset/175416>

Comment 5 WebKit Commit Bot 2014-10-31 12:28:12 PDT

All reviewed patches have been landed.  Closing bug.