| Summary: | Add --json flag to run-bindings-tests | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jake Nielsen <jake.nielsen.webkit> | ||||||
| Component: | Tools / Tests | Assignee: | Srinivasan Vijayaraghavan <webkit> | ||||||
| Status: | RESOLVED DUPLICATE | ||||||||
| Severity: | Normal | CC: | ap, commit-queue, dbates, glenn, webkit | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=168626 | ||||||||
| Attachments: |
|
||||||||
|
Description
Jake Nielsen
2014-10-30 17:48:03 PDT
Created attachment 240717 [details]
First Attempt
I want to fiddle a little more before this gets CQ+ed, but I'm about to leave for the day. Any feedback would be much appreciated so I can roll it in when I make changes tomorrow morning.
Attachment 240717 [details] did not pass style-queue:
ERROR: Tools/Scripts/webkitpy/bindings/main.py:44: whitespace before ':' [pep8/E203] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 240748 [details]
results.html displays the JSON correctly.
Comment on attachment 240748 [details]
results.html displays the JSON correctly.
This does not seem like the correct approach. It is weird that passing --json will write both human readable output to standard error and write JSON to standard output because both outputs will be visible to a person that runs run-bindings-tests in their terminal (assuming a default configured terminal). Instead we should have the --json flag take a path to an output file and write the JSON-formatted test results to this file. We should not change any other behavior of the script run-bindings-tests.
*** This bug has been marked as a duplicate of bug 168626 *** |