Bug 138228

Summary: Migrate ComplexTextControllerCoreText to use SPI instead of WKSI
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, jonlee, mjs, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Description Myles C. Maxfield 2014-10-30 14:08:17 PDT 
Migrate ComplexTextControllerCoreText to use SPI instead of WKSI
Comment 1 Myles C. Maxfield 2014-10-30 14:09:53 PDT 
Created attachment 240694 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-10-30 14:12:01 PDT 
Comment on attachment 240694 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240694&action=review

> Source/WebCore/platform/spi/cocoa/CoreTextSPI.h:40
> +extern "C" CGSize CTRunGetInitialAdvance(CTRunRef run);
> +extern "C" CTLineRef CTLineCreateWithUniCharProvider(CTUniCharProviderCallback provide, CTUniCharDisposeCallback dispose, void* refCon);
> +extern "C" CTTypesetterRef CTTypesetterCreateWithUniCharProviderAndOptions(CTUniCharProviderCallback provide, CTUniCharDisposeCallback dispose, void* refCon, CFDictionaryRef options);

Maybe use an extern "C" {} block
Comment 3 Myles C. Maxfield 2014-10-30 14:17:45 PDT 
https://trac.webkit.org/r175379