Bug 138228

Summary: Migrate ComplexTextControllerCoreText to use SPI instead of WKSI
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, jonlee, mjs, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Myles C. Maxfield
Reported 2014-10-30 14:08:17 PDT
Migrate ComplexTextControllerCoreText to use SPI instead of WKSI
Attachments
Patch (7.51 KB, patch)
2014-10-30 14:09 PDT, Myles C. Maxfield 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2014-10-30 14:09:53 PDT
Created attachment 240694 [details] Patch
Simon Fraser (smfr)
Comment 2 2014-10-30 14:12:01 PDT
Comment on attachment 240694 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240694&action=review > Source/WebCore/platform/spi/cocoa/CoreTextSPI.h:40 > +extern "C" CGSize CTRunGetInitialAdvance(CTRunRef run); > +extern "C" CTLineRef CTLineCreateWithUniCharProvider(CTUniCharProviderCallback provide, CTUniCharDisposeCallback dispose, void* refCon); > +extern "C" CTTypesetterRef CTTypesetterCreateWithUniCharProviderAndOptions(CTUniCharProviderCallback provide, CTUniCharDisposeCallback dispose, void* refCon, CFDictionaryRef options); Maybe use an extern "C" {} block
Myles C. Maxfield
Comment 3 2014-10-30 14:17:45 PDT
https://trac.webkit.org/r175379
Note You need to log in before you can comment on or make changes to this bug.