Bug 138223

Summary: Long spins under rangeExpandedAroundPosition on Yahoo Mail
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, enrica, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch enrica: review+

Tim Horton
Reported 2014-10-30 12:29:37 PDT
Long spins under rangeExpandedAroundPosition on Yahoo Mail
Attachments
Patch (6.86 KB, patch)
2014-10-30 12:31 PDT, Tim Horton 		enrica: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-10-30 12:31:32 PDT
Created attachment 240687 [details] Patch
Enrica Casucci
Comment 2 2014-10-30 12:40:14 PDT
Comment on attachment 240687 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240687&action=review > Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:517 > + end = end.previous(Character); What happens when you reach a null position before the number of characters to expand? I think you should handle that case in both directions.
Tim Horton
Comment 3 2014-10-30 12:46:46 PDT
Comment on attachment 240687 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240687&action=review >> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:517 >> + end = end.previous(Character); > > What happens when you reach a null position before the number of characters to expand? I think you should handle that case in both directions. Interesting! I'm surprised the telephone number code I stole this from has never been a problem.
Tim Horton
Comment 4 2014-10-30 15:29:56 PDT
It looks like the positions never become null, they just climb the tree and then stick at one end or the other. Works exactly as you'd hope.
Enrica Casucci
Comment 5 2014-10-30 15:32:20 PDT
Comment on attachment 240687 [details] Patch Thanks for looking into that!. Looks good to me.
Tim Horton
Comment 6 2014-10-30 15:38:16 PDT
http://trac.webkit.org/changeset/175388
Note You need to log in before you can comment on or make changes to this bug.