Bug 138210

Summary: [GTK] Minibrowser : Add keyborad support for creating new window in GTK Minibrowser
Product: WebKit Reporter: Rohit <kumar.rohit>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: bugs-noreply, buildbot, cgarcia, clopez, mrobinson, ossy, pnormand, rniwa, svillar, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mcatanzaro: review+

Rohit
Reported 2014-10-30 02:55:21 PDT
Add keyboard support for creating new window in Webkit GTK Minibrowser using 'ctrl' + 'n' keys.
Attachments
Patch (2.38 KB, patch)
2014-10-30 03:05 PDT, Rohit 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rohit
Comment 1 2014-10-30 03:05:23 PDT
Created attachment 240664 [details] Patch
Csaba Osztrogonác
Comment 2 2015-05-15 04:44:55 PDT
cc-ing more GTK reviewer
Michael Catanzaro
Comment 3 2016-01-06 20:24:49 PST
Comment on attachment 240664 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240664&action=review Thanks, sorry for the late review. > Tools/ChangeLog:3 > + [GTK] Minibrowser : Add keyborad support for creating new window in GTK Minibrowser keyborad -> keyboard > Tools/MiniBrowser/gtk/BrowserWindow.c:566 > +static void createNewWindow(BrowserWindow *window, gpointer user_data) user_data -> userData
Note You need to log in before you can comment on or make changes to this bug.