Bug 138210

Summary:

[GTK] Minibrowser : Add keyborad support for creating new window in GTK Minibrowser

Product:

WebKit

Reporter:

Rohit <kumar.rohit>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

NEW ---

Severity:

Normal

CC:

bugs-noreply, buildbot, cgarcia, clopez, mrobinson, ossy, pnormand, rniwa, svillar, zan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mcatanzaro: review+

Description Rohit 2014-10-30 02:55:21 PDT

Add keyboard support for creating new window in Webkit GTK Minibrowser using 'ctrl' + 'n' keys.

Comment 1 Rohit 2014-10-30 03:05:23 PDT

Created attachment 240664 [details]
Patch

Comment 2 Csaba Osztrogonác 2015-05-15 04:44:55 PDT

cc-ing more GTK reviewer

Comment 3 Michael Catanzaro 2016-01-06 20:24:49 PST

Comment on attachment 240664 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240664&action=review

Thanks, sorry for the late review.

> Tools/ChangeLog:3
> +        [GTK] Minibrowser : Add keyborad support for creating new window in GTK Minibrowser

keyborad -> keyboard

> Tools/MiniBrowser/gtk/BrowserWindow.c:566
> +static void createNewWindow(BrowserWindow *window, gpointer user_data)

user_data -> userData