Bug 138205

Summary: Add diagnostic logging to track page loads.
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, japhet, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch.
none
Updated patch none

Eric Carlson
Reported 2014-10-29 18:45:57 PDT
Add diagnostic logging to track the number of page loads.
Attachments
Proposed patch. (3.15 KB, patch)
2014-10-29 19:17 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Updated patch (3.15 KB, patch)
2014-10-29 19:28 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2014-10-29 18:46:40 PDT
<rdar://problem/18173017>
Radar WebKit Bug Importer
Comment 2 2014-10-29 18:47:01 PDT
<rdar://problem/18820041>
Eric Carlson
Comment 3 2014-10-29 19:17:45 PDT
Created attachment 240649 [details] Proposed patch.
WebKit Commit Bot
Comment 4 2014-10-29 19:19:03 PDT
Attachment 240649 [details] did not pass style-queue: ERROR: Source/WebCore/loader/FrameLoader.cpp:47: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Carlson
Comment 5 2014-10-29 19:28:13 PDT
Created attachment 240650 [details] Updated patch > ERROR: Source/WebCore/loader/FrameLoader.cpp:47: Alphabetical sorting problem. [build/include_order] [4] Oh the horror!
WebKit Commit Bot
Comment 6 2014-10-30 12:04:31 PDT
Comment on attachment 240650 [details] Updated patch Clearing flags on attachment: 240650 Committed r175375: <http://trac.webkit.org/changeset/175375>
WebKit Commit Bot
Comment 7 2014-10-30 12:04:38 PDT
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 8 2015-02-20 15:47:53 PST
Comment on attachment 240650 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=240650&action=review > Source/WebCore/loader/FrameLoader.cpp:2270 > + page->chrome().client().logDiagnosticMessage(DiagnosticLoggingKeys::pageLoadedKey(), emptyString(), error.isNull() ? DiagnosticLoggingKeys::passKey() : DiagnosticLoggingKeys::failKey()); This seems to log for each frame load (included subframes). Was this the intention?
Note You need to log in before you can comment on or make changes to this bug.