Summary: | Clean up virtual functions in inspector/ | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
Component: | Web Inspector | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Enhancement | CC: | commit-queue, graouts, joepeck, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Chris Dumez
2014-10-29 15:21:06 PDT
Created attachment 240631 [details]
Patch
Comment on attachment 240631 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240631&action=review r=me! > Source/WebCore/inspector/PageConsoleAgent.h:50 > - virtual bool isWorkerAgent() const override { return false; } > - > private: > + virtual bool isWorkerAgent() const override { return false; } I never really understood this (moving public virtual functions to private). They are still public, so why not leave it public? Comment on attachment 240631 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240631&action=review >> Source/WebCore/inspector/PageConsoleAgent.h:50 >> + virtual bool isWorkerAgent() const override { return false; } > > I never really understood this (moving public virtual functions to private). They are still public, so why not leave it public? Calling PageConsoleAgent::isWorkerAgent() should give you a compile error now because it *is* private (if the instance is a PageConsoleAgent, not a generic WebConsoleAgent). This makes sure we don't do unnecessary type checks in the code as explained in the Changelog. Comment on attachment 240631 [details] Patch Clearing flags on attachment: 240631 Committed r175355: <http://trac.webkit.org/changeset/175355> All reviewed patches have been landed. Closing bug. |