Bug 138178

Summary: Implement action menus for data detected items
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, commit-queue, conrad_shultz, enrica, mitz, sam, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch andersca: review+

Tim Horton
Reported 2014-10-29 10:41:51 PDT
<rdar://problem/18709436>
Attachments
patch (318.23 KB, patch)
2014-10-29 10:50 PDT, Tim Horton 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-10-29 10:50:04 PDT
Created attachment 240611 [details] patch
WebKit Commit Bot
Comment 2 2014-10-29 10:53:19 PDT
Attachment 240611 [details] did not pass style-queue: ERROR: Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:63: Alphabetical sorting problem. [build/include_order] [4] ERROR: WebKitLibraries/WebKitSystemInterface.h:132: The parameter name "controlSize" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: WebKitLibraries/WebKitSystemInterface.h:134: The parameter name "actionContext" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/Shared/mac/ActionMenuHitTestResult.mm:84: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/Shared/mac/ActionMenuHitTestResult.mm:84: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 5 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2014-10-29 11:42:51 PDT
Comment on attachment 240611 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=240611&action=review > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:400 > + DDActionContext *actionContext = _hitTestResult.actionContext.get(); > + if (actionContext) { Can put these on a single line.
Tim Horton
Comment 4 2014-10-29 11:48:30 PDT
http://trac.webkit.org/changeset/175335
Chris Dumez
Comment 5 2014-10-29 15:03:11 PDT
Comment on attachment 240611 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=240611&action=review > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:401 > + WKSetDDActionContextIsForActionMenu(actionContext); My build fails saying this one is undefined.
Tim Horton
Comment 6 2014-10-29 15:14:33 PDT
(In reply to comment #5) > Comment on attachment 240611 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=240611&action=review > > > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:401 > > + WKSetDDActionContextIsForActionMenu(actionContext); > > My build fails saying this one is undefined. We sorted this out.
Note You need to log in before you can comment on or make changes to this bug.