Summary: | [EME][Mac] MediaKeySession type "keyrelease" is ignored. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||
Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, eric.carlson, glenn, philipj, sergio | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Jer Noble
2014-10-29 08:47:48 PDT
Created attachment 240604 [details]
Patch
Comment on attachment 240604 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240604&action=review acknowledged > Source/WebCore/ChangeLog:12 > + Also, the code which validates update() requests needs to allow updates of containing the string Nit: "... allow updates OF containing ..." => "... allow updates containing ..." > Source/WebCore/ChangeLog:13 > + "acknowledeged", so that clients can request the confirmation messages be discarded. Nit: "acknowledeged" => "acknowledged" > Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:202 > + if (m_mode == KeyRelease) > + return false; > + Does this add support for "acknowledged"? Comment on attachment 240604 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240604&action=review >> Source/WebCore/ChangeLog:12 >> + Also, the code which validates update() requests needs to allow updates of containing the string > > Nit: "... allow updates OF containing ..." => "... allow updates containing ..." Changed. >> Source/WebCore/ChangeLog:13 >> + "acknowledeged", so that clients can request the confirmation messages be discarded. > > Nit: "acknowledeged" => "acknowledged" Changed. >> Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:202 >> + > > Does this add support for "acknowledged"? Only for "keyrelease" sessions. "acknowledged" was already working for the normal flow, i.e., when calling mediaKeySession.stop(). Committed r175331: <http://trac.webkit.org/changeset/175331> |