Bug 138175

Summary: [EME][Mac] MediaKeySession type "keyrelease" is ignored.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, glenn, philipj, sergio
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch eric.carlson: review+

Jer Noble
Reported 2014-10-29 08:47:48 PDT
[EME][Mac] MediaKeySession type "keyrelease" is ignored.
Attachments
Patch (3.40 KB, patch)
2014-10-29 09:16 PDT, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2014-10-29 09:16:22 PDT
Created attachment 240604 [details] Patch
Eric Carlson
Comment 2 2014-10-29 09:38:46 PDT
Comment on attachment 240604 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240604&action=review acknowledged > Source/WebCore/ChangeLog:12 > + Also, the code which validates update() requests needs to allow updates of containing the string Nit: "... allow updates OF containing ..." => "... allow updates containing ..." > Source/WebCore/ChangeLog:13 > + "acknowledeged", so that clients can request the confirmation messages be discarded. Nit: "acknowledeged" => "acknowledged" > Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:202 > + if (m_mode == KeyRelease) > + return false; > + Does this add support for "acknowledged"?
Jer Noble
Comment 3 2014-10-29 10:47:38 PDT
Comment on attachment 240604 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240604&action=review >> Source/WebCore/ChangeLog:12 >> + Also, the code which validates update() requests needs to allow updates of containing the string > > Nit: "... allow updates OF containing ..." => "... allow updates containing ..." Changed. >> Source/WebCore/ChangeLog:13 >> + "acknowledeged", so that clients can request the confirmation messages be discarded. > > Nit: "acknowledeged" => "acknowledged" Changed. >> Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:202 >> + > > Does this add support for "acknowledged"? Only for "keyrelease" sessions. "acknowledged" was already working for the normal flow, i.e., when calling mediaKeySession.stop().
Jer Noble
Comment 4 2014-10-29 10:54:08 PDT
Committed r175331: <http://trac.webkit.org/changeset/175331>
Jer Noble
Comment 5 2014-12-16 13:28:33 PST
<rdar://problem/19269059>
Note You need to log in before you can comment on or make changes to this bug.