Bug 138166

Summary: Clean up virtual functions in html/
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, commit-queue, darin, kling, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Chris Dumez 2014-10-28 21:02:43 PDT 
Clean up virtual functions in html/ by:
- Making virtual functions final when possible
- Making classes final when possible
- Using 'override' when appropriate
- Explicitly marking functions / destructors as virtual when they are
  inherently virtual
- Dropping virtual destructors when the class does not have subclasses
  and mark the class as final, to get rid of unnecessary vtables
- Making isXXX() virtual functions private on XXX classes to avoid
  unnecessary type checks
- De-virtualizing some functions that do not need to be virtual
- Dropping final for virtual functions in classes already marked as
  final
Comment 1 Chris Dumez 2014-10-28 21:21:48 PDT 
Created attachment 240592 [details]
Patch
Comment 2 Andreas Kling 2014-10-29 00:11:06 PDT 
Comment on attachment 240592 [details]
Patch

r=me!
Comment 3 WebKit Commit Bot 2014-10-29 08:09:59 PDT 
Comment on attachment 240592 [details]
Patch

Clearing flags on attachment: 240592

Committed r175328: <http://trac.webkit.org/changeset/175328>
Comment 4 WebKit Commit Bot 2014-10-29 08:10:04 PDT 
All reviewed patches have been landed.  Closing bug.