Bug 138160

Summary: Unify logic in RunTests.run() to run the Python unit tests
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cjerdonek, commit-queue, ddkilzer, glenn, jake.nielsen.webkit, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 137667    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch mrobinson: review+

Daniel Bates
Reported 2014-10-28 17:13:44 PDT
Currently we duplicate logic when running the RunTest step interactively and non-interacrtively for determining the path to the test-webkitpy application and printing a log message to the console to inform a person that we are running the Python unit tests. We should unify these code paths.
Attachments
Patch (3.39 KB, patch)
2014-10-28 17:34 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (3.39 KB, patch)
2014-10-28 18:03 PDT, Daniel Bates 		mrobinson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2014-10-28 17:34:11 PDT
Created attachment 240583 [details] Patch
Daniel Bates
Comment 2 2014-10-28 18:03:04 PDT
Created attachment 240584 [details] Patch Rebased patch following the landing of the patch for bug #137667.
Daniel Bates
Comment 3 2014-10-28 18:28:31 PDT
Committed r175295: <http://trac.webkit.org/changeset/175295>
Note You need to log in before you can comment on or make changes to this bug.