| Summary: | Implement WKPageSetMuted(bool) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ada Chan <adachan> | ||||||
| Component: | WebKit2 | Assignee: | Ada Chan <adachan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | andersca, commit-queue, sam | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 138150 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Ada Chan
2014-10-28 16:49:22 PDT
Created attachment 240615 [details]
Patch
Attachment 240615 [details] did not pass style-queue:
ERROR: Source/WebCore/WebCore.exp.in:0: Source/WebCore/WebCore.exp.in should be sorted, use Tools/Scripts/sort-export-file script [list/order] [5]
Total errors found: 1 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 240617 [details]
Patch, fixed the ordering issue in WebCore.exp.in
Comment on attachment 240617 [details]
Patch, fixed the ordering issue in WebCore.exp.in
I think you also need to pass "muted" as a web page creation parameter so you'll handle the web process crashing. This is a good start though!
Thanks Anders! I've filed https://bugs.webkit.org/show_bug.cgi?id=138195 to handle restoring the muted state after web process crashes. Committed: http://trac.webkit.org/changeset/175351 |