Bug 138158

Summary: Implement WKPageSetMuted(bool)
Product: WebKit Reporter: Ada Chan <adachan>
Component: WebKit2Assignee: Ada Chan <adachan>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 138150    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch, fixed the ordering issue in WebCore.exp.in andersca: review+

Ada Chan
Reported 2014-10-28 16:49:22 PDT
Implement WKPageSetMuted(bool). Needed for <rdar://problem/18398191>.
Attachments
Patch (7.52 KB, patch)
2014-10-29 13:06 PDT, Ada Chan 		no flags
DetailsFormatted DiffDiff
Patch, fixed the ordering issue in WebCore.exp.in (7.60 KB, patch)
2014-10-29 13:23 PDT, Ada Chan 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ada Chan
Comment 1 2014-10-29 13:06:19 PDT
Created attachment 240615 [details] Patch
WebKit Commit Bot
Comment 2 2014-10-29 13:07:49 PDT
Attachment 240615 [details] did not pass style-queue: ERROR: Source/WebCore/WebCore.exp.in:0: Source/WebCore/WebCore.exp.in should be sorted, use Tools/Scripts/sort-export-file script [list/order] [5] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ada Chan
Comment 3 2014-10-29 13:23:59 PDT
Created attachment 240617 [details] Patch, fixed the ordering issue in WebCore.exp.in
Anders Carlsson
Comment 4 2014-10-29 14:30:38 PDT
Comment on attachment 240617 [details] Patch, fixed the ordering issue in WebCore.exp.in I think you also need to pass "muted" as a web page creation parameter so you'll handle the web process crashing. This is a good start though!
Ada Chan
Comment 5 2014-10-29 15:57:45 PDT
Thanks Anders! I've filed https://bugs.webkit.org/show_bug.cgi?id=138195 to handle restoring the muted state after web process crashes.
Ada Chan
Comment 6 2014-10-29 16:01:26 PDT
Committed: http://trac.webkit.org/changeset/175351
Note You need to log in before you can comment on or make changes to this bug.