Bug 138153

Summary: Remove MediaSessionClient::hasMediaCharacteristics() and MediaSessionClient::mediaStateDidChange()
Product: WebKit Reporter: Ada Chan <adachan>
Component: MediaAssignee: Ada Chan <adachan>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, philipj, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch jer.noble: review+

Ada Chan
Reported 2014-10-28 15:15:14 PDT
After http://trac.webkit.org/changeset/175273, Document no longer keeps a set of MediaSessions and it doesn't need to query each MediaSession for its characteristics and play state. MediaSessionClient::hasMediaCharacteristics() is no longer needed and MediaSessionClient::mediaStateDidChange() can be removed if HTMLMediaElement calls Document::updateIsPlayingAudio() after m_playing has changed.
Attachments
Patch (10.25 KB, patch)
2014-10-28 16:34 PDT, Ada Chan 		jer.noble: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ada Chan
Comment 1 2014-10-28 16:34:10 PDT
Created attachment 240576 [details] Patch
Jer Noble
Comment 2 2014-10-29 10:17:33 PDT
Comment on attachment 240576 [details] Patch r=me, with one nit: The comment you made above is really good, and I'd like to see it in the ChangeLog too.
Ada Chan
Comment 3 2014-10-29 10:42:17 PDT
Thanks Jer. Committed: http://trac.webkit.org/changeset/175330
Note You need to log in before you can comment on or make changes to this bug.