Bug 138153

Summary:

Remove MediaSessionClient::hasMediaCharacteristics() and MediaSessionClient::mediaStateDidChange()

Product:

WebKit

Reporter:

Ada Chan <adachan>

Component:

Media

Assignee:

Ada Chan <adachan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

calvaris, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, philipj, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	jer.noble: review+

Description Ada Chan 2014-10-28 15:15:14 PDT

After http://trac.webkit.org/changeset/175273, Document no longer keeps a set of MediaSessions and it doesn't need to query each MediaSession for its characteristics and play state.  MediaSessionClient::hasMediaCharacteristics() is no longer needed and MediaSessionClient::mediaStateDidChange() can be removed if HTMLMediaElement calls Document::updateIsPlayingAudio() after m_playing has changed.

Comment 1 Ada Chan 2014-10-28 16:34:10 PDT

Created attachment 240576 [details]
Patch

Comment 2 Jer Noble 2014-10-29 10:17:33 PDT

Comment on attachment 240576 [details]
Patch

r=me, with one nit: The comment you made above is really good, and I'd like to see it in the ChangeLog too.

Comment 3 Ada Chan 2014-10-29 10:42:17 PDT

Thanks Jer.

Committed:
http://trac.webkit.org/changeset/175330