Bug 138152

Summary: Generalize dirtying of parent's line boxes when taking a renderer out of tree.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, koivisto, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Andreas Kling 2014-10-28 15:08:34 PDT
We currently have calls to dirtyLinesFromChangedChild() scattered in various subclass implementations of RenderObject::willBeDestroyed().

I think we can do this in RenderElement::willBeRemovedFromTree() instead. It makes more sense to me that the act of removing the renderer from the tree is what dirties other things on the same line, not its actual destruction.
Comment 1 Andreas Kling 2014-10-28 15:09:06 PDT
Created attachment 240573 [details]
Patch
Comment 2 WebKit Commit Bot 2014-10-29 16:02:07 PDT
Comment on attachment 240573 [details]
Patch

Clearing flags on attachment: 240573

Committed r175352: <http://trac.webkit.org/changeset/175352>
Comment 3 WebKit Commit Bot 2014-10-29 16:02:10 PDT
All reviewed patches have been landed.  Closing bug.