Bug 138152

Summary: Generalize dirtying of parent's line boxes when taking a renderer out of tree.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, koivisto, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Andreas Kling
Reported 2014-10-28 15:08:34 PDT
We currently have calls to dirtyLinesFromChangedChild() scattered in various subclass implementations of RenderObject::willBeDestroyed(). I think we can do this in RenderElement::willBeRemovedFromTree() instead. It makes more sense to me that the act of removing the renderer from the tree is what dirties other things on the same line, not its actual destruction.
Attachments
Patch (4.99 KB, patch)
2014-10-28 15:09 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-10-28 15:09:06 PDT
Created attachment 240573 [details] Patch
WebKit Commit Bot
Comment 2 2014-10-29 16:02:07 PDT
Comment on attachment 240573 [details] Patch Clearing flags on attachment: 240573 Committed r175352: <http://trac.webkit.org/changeset/175352>
WebKit Commit Bot
Comment 3 2014-10-29 16:02:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.