Bug 138148

Summary:

Clean up virtual functions in accessibility/

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Accessibility

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, cfleizach, commit-queue, darin, dmazzoni, eric.carlson, glenn, jcraig, jdiggs, jer.noble, kling, mario, philipj, samuel_white, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Chris Dumez 2014-10-28 14:18:40 PDT

Clean up virtual functions in accessibility/ by:
- Marking classes as final when suitable
- Marking virtual functions as final when suitable
- Dropping final on virtual functions in classes that are already final
- Make isXXX() virtual type checking functions in XXX classes to avoid useless type checks

Comment 1 Radar WebKit Bug Importer 2014-10-28 14:18:56 PDT

<rdar://problem/18801520>

Comment 2 Chris Dumez 2014-10-28 14:55:38 PDT

Created attachment 240572 [details]
Patch

Comment 3 WebKit Commit Bot 2014-10-28 15:42:34 PDT

Comment on attachment 240572 [details]
Patch

Clearing flags on attachment: 240572

Committed r175278: <http://trac.webkit.org/changeset/175278>

Comment 4 WebKit Commit Bot 2014-10-28 15:42:39 PDT

All reviewed patches have been landed.  Closing bug.