Bug 138148

Summary: Clean up virtual functions in accessibility/
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: AccessibilityAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, darin, dmazzoni, eric.carlson, glenn, jcraig, jdiggs, jer.noble, kling, mario, philipj, samuel_white, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2014-10-28 14:18:40 PDT
Clean up virtual functions in accessibility/ by: - Marking classes as final when suitable - Marking virtual functions as final when suitable - Dropping final on virtual functions in classes that are already final - Make isXXX() virtual type checking functions in XXX classes to avoid useless type checks
Attachments
Patch (36.09 KB, patch)
2014-10-28 14:55 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-10-28 14:18:56 PDT
<rdar://problem/18801520>
Chris Dumez
Comment 2 2014-10-28 14:55:38 PDT
Created attachment 240572 [details] Patch
WebKit Commit Bot
Comment 3 2014-10-28 15:42:34 PDT
Comment on attachment 240572 [details] Patch Clearing flags on attachment: 240572 Committed r175278: <http://trac.webkit.org/changeset/175278>
WebKit Commit Bot
Comment 4 2014-10-28 15:42:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.