Bug 138147

Summary: [EME] Add Setting for accessing storage location for MediaKeys data
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, calvaris, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jonlee, philipj, rniwa, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137120    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Jer Noble 2014-10-28 13:23:47 PDT 
[EME] Add ChromeClient method for accessing storage location for MediaKeys data
Comment 1 Jer Noble 2014-10-28 13:27:31 PDT 
Created attachment 240568 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2014-10-29 16:04:26 PDT 
<rdar://problem/18818269>
Comment 3 Jer Noble 2014-10-29 22:51:48 PDT 
Created attachment 240659 [details]
Patch
Comment 4 Brady Eidson 2014-10-30 14:16:17 PDT 
Comment on attachment 240659 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240659&action=review

> Source/WebCore/page/ChromeClient.h:450
> +    virtual String mediaKeysStorageDirectoryForOrigin(SecurityOrigin*) { return emptyString(); }

I don't think the ChromeClient is the place for this.  I think there's way more appropriate places to put directory accessors.
Comment 5 Jer Noble 2014-10-30 14:52:39 PDT 
Comment on attachment 240659 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240659&action=review

>> Source/WebCore/page/ChromeClient.h:450
>> +    virtual String mediaKeysStorageDirectoryForOrigin(SecurityOrigin*) { return emptyString(); }
> 
> I don't think the ChromeClient is the place for this.  I think there's way more appropriate places to put directory accessors.

Okay, I'll move these methods into Settings.
Comment 6 Jer Noble 2014-10-30 15:45:04 PDT 
Created attachment 240710 [details]
Patch
Comment 7 WebKit Commit Bot 2014-10-30 17:18:22 PDT 
Comment on attachment 240710 [details]
Patch

Clearing flags on attachment: 240710

Committed r175400: <http://trac.webkit.org/changeset/175400>
Comment 8 WebKit Commit Bot 2014-10-30 17:18:27 PDT 
All reviewed patches have been landed.  Closing bug.