Bug 138147

Summary: [EME] Add Setting for accessing storage location for MediaKeys data
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, calvaris, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jonlee, philipj, rniwa, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137120    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Jer Noble
Reported 2014-10-28 13:23:47 PDT
[EME] Add ChromeClient method for accessing storage location for MediaKeys data
Attachments
Patch (12.83 KB, patch)
2014-10-28 13:27 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (12.59 KB, patch)
2014-10-29 22:51 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (13.98 KB, patch)
2014-10-30 15:45 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2014-10-28 13:27:31 PDT
Created attachment 240568 [details] Patch
Radar WebKit Bug Importer
Comment 2 2014-10-29 16:04:26 PDT
<rdar://problem/18818269>
Jer Noble
Comment 3 2014-10-29 22:51:48 PDT
Created attachment 240659 [details] Patch
Brady Eidson
Comment 4 2014-10-30 14:16:17 PDT
Comment on attachment 240659 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240659&action=review > Source/WebCore/page/ChromeClient.h:450 > + virtual String mediaKeysStorageDirectoryForOrigin(SecurityOrigin*) { return emptyString(); } I don't think the ChromeClient is the place for this. I think there's way more appropriate places to put directory accessors.
Jer Noble
Comment 5 2014-10-30 14:52:39 PDT
Comment on attachment 240659 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240659&action=review >> Source/WebCore/page/ChromeClient.h:450 >> + virtual String mediaKeysStorageDirectoryForOrigin(SecurityOrigin*) { return emptyString(); } > > I don't think the ChromeClient is the place for this. I think there's way more appropriate places to put directory accessors. Okay, I'll move these methods into Settings.
Jer Noble
Comment 6 2014-10-30 15:45:04 PDT
Created attachment 240710 [details] Patch
WebKit Commit Bot
Comment 7 2014-10-30 17:18:22 PDT
Comment on attachment 240710 [details] Patch Clearing flags on attachment: 240710 Committed r175400: <http://trac.webkit.org/changeset/175400>
WebKit Commit Bot
Comment 8 2014-10-30 17:18:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.