Bug 138132

Summary: [EFL] Remove unnecessary defines from OptionsEfl.cmake
Product: WebKit Reporter: Tibor Mészáros <mtiborinf>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, gyuyoung.kim, lucas.de.marchi, ossy, rakuco, ryuan.choi, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Tibor Mészáros
Reported 2014-10-28 07:21:15 PDT
WTF_USE_GLIB, WTF_USE_SOUP, WTF_USE_CAIRO, WTF_USE_FREETYPE and WTF_USE_HARFBUZZ defines are always true and can be defined in Platform.h, as GTK already does. It is unnecessary to define them in OptionsEfl.cmake, it only makes the compiling commands longer without a good reason.
Attachments
Patch (2.28 KB, patch)
2014-10-28 07:25 PDT, Tibor Mészáros 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tibor Mészáros
Comment 1 2014-10-28 07:25:47 PDT
Created attachment 240536 [details] Patch
WebKit Commit Bot
Comment 2 2014-10-28 09:30:50 PDT
Comment on attachment 240536 [details] Patch Clearing flags on attachment: 240536 Committed r175253: <http://trac.webkit.org/changeset/175253>
WebKit Commit Bot
Comment 3 2014-10-28 09:30:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.