Bug 138132 - [EFL] Remove unnecessary defines from OptionsEfl.cmake
Summary: [EFL] Remove unnecessary defines from OptionsEfl.cmake
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-28 07:21 PDT by Tibor Mészáros
Modified: 2014-10-28 09:30 PDT (History)
9 users (show)

See Also:

Attachments
Patch (2.28 KB, patch)
2014-10-28 07:25 PDT, Tibor Mészáros 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tibor Mészáros 2014-10-28 07:21:15 PDT 
WTF_USE_GLIB, WTF_USE_SOUP, WTF_USE_CAIRO, WTF_USE_FREETYPE and WTF_USE_HARFBUZZ
defines are always true and can be defined in Platform.h, as GTK already does.

It is unnecessary to define them in OptionsEfl.cmake, it only
makes the compiling commands longer without a good reason.
Comment 1 Tibor Mészáros 2014-10-28 07:25:47 PDT 
Created attachment 240536 [details]
Patch
Comment 2 WebKit Commit Bot 2014-10-28 09:30:50 PDT 
Comment on attachment 240536 [details]
Patch

Clearing flags on attachment: 240536

Committed r175253: <http://trac.webkit.org/changeset/175253>
Comment 3 WebKit Commit Bot 2014-10-28 09:30:55 PDT 
All reviewed patches have been landed.  Closing bug.