| Summary: | Simplified some JSObject methods for converting arrays to ArrayStorage shape | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, fpizlo, ggaren, mhahnenb, mmirman, msaboff, oliver | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 240522 [details]
the patch.
Comment on attachment 240522 [details] the patch. Clearing flags on attachment: 240522 Committed r175240: <http://trac.webkit.org/changeset/175240> All reviewed patches have been landed. Closing bug. |
Currently, for each Undecided, Int32, Double, and Contiguous array shapes, there are 3 JSObject methods to convert them to ArrayStorage shape: ArrayStorage* convert<shape>ToArrayStorage(VM&, NonPropertyTransition, unsigned neededLength); ArrayStorage* convert<shape>ToArrayStorage(VM&, NonPropertyTransition); ArrayStorage* convert<shape>ToArrayStorage(VM&); However, the neededLength that is passed is always m_butterfly->vectorLength(). Hence, the method that takes a neededLength is really not needed.