Bug 138106

Summary:

AX: input type=hidden is being exposed when aria-hidden=false

Product:

WebKit

Reporter:

chris fleizach <cfleizach>

Component:

Accessibility

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, buildbot, commit-queue, dmazzoni, jcraig, jdiggs, mario, rniwa, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	benjamin: review+, benjamin: commit-queue-

chris fleizach

Reported 2014-10-27 15:00:05 PDT

If someone sticks a input type=hidden inside an aria-hidden=false region, then that will be exposed as a text field <rdar://problem/18534039>

Attachments
patch (4.28 KB, patch) 2014-10-27 15:47 PDT, chris fleizach	benjamin: review+ benjamin: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

chris fleizach

Comment 1 2014-10-27 15:47:58 PDT

Created attachment 240509 [details] patch

Benjamin Poulain

Comment 2 2014-10-27 17:20:18 PDT

Comment on attachment 240509 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=240509&action=review > LayoutTests/accessibility/input-type-hidden-in-aria-hidden-false.html:21 > + var content = accessibilityController.accessibleElementById("content"); > + shouldBe("content.childrenCount", "0"); For coverage I suggest the following: 1) Do not have aria-hidden="false" on #content, test childrenCount 2) Add aria-hidden, test childrenCount 3) Change to aria-hidden=true, test childrenCount 4) Change to aria-hidden=false, test childrenCount That way all cases of [type=hidden] are covered. > LayoutTests/accessibility/input-type-hidden-in-aria-hidden-false.html:23 > + document.getElementById("content").style.visibility = "hidden"; Forgot this?

chris fleizach

Comment 3 2014-10-27 18:17:08 PDT

(In reply to comment #2) > Comment on attachment 240509 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=240509&action=review > > > LayoutTests/accessibility/input-type-hidden-in-aria-hidden-false.html:21 > > + var content = accessibilityController.accessibleElementById("content"); > > + shouldBe("content.childrenCount", "0"); > > For coverage I suggest the following: > 1) Do not have aria-hidden="false" on #content, test childrenCount > 2) Add aria-hidden, test childrenCount > 3) Change to aria-hidden=true, test childrenCount > 4) Change to aria-hidden=false, test childrenCount > > That way all cases of [type=hidden] are covered. > > > LayoutTests/accessibility/input-type-hidden-in-aria-hidden-false.html:23 > > + document.getElementById("content").style.visibility = "hidden"; > > Forgot this? Thanks! I'll make these changes

chris fleizach

Comment 4 2014-10-27 22:39:09 PDT

http://trac.webkit.org/changeset/175241

Note You need to log in before you can comment on or make changes to this bug.