| Summary: | AX: input type=hidden is being exposed when aria-hidden=false | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | chris fleizach <cfleizach> | ||||
| Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aboxhall, apinheiro, buildbot, commit-queue, dmazzoni, jcraig, jdiggs, mario, rniwa, samuel_white, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
chris fleizach
2014-10-27 15:00:05 PDT
Created attachment 240509 [details]
patch
Comment on attachment 240509 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=240509&action=review > LayoutTests/accessibility/input-type-hidden-in-aria-hidden-false.html:21 > + var content = accessibilityController.accessibleElementById("content"); > + shouldBe("content.childrenCount", "0"); For coverage I suggest the following: 1) Do not have aria-hidden="false" on #content, test childrenCount 2) Add aria-hidden, test childrenCount 3) Change to aria-hidden=true, test childrenCount 4) Change to aria-hidden=false, test childrenCount That way all cases of [type=hidden] are covered. > LayoutTests/accessibility/input-type-hidden-in-aria-hidden-false.html:23 > + document.getElementById("content").style.visibility = "hidden"; Forgot this? (In reply to comment #2) > Comment on attachment 240509 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=240509&action=review > > > LayoutTests/accessibility/input-type-hidden-in-aria-hidden-false.html:21 > > + var content = accessibilityController.accessibleElementById("content"); > > + shouldBe("content.childrenCount", "0"); > > For coverage I suggest the following: > 1) Do not have aria-hidden="false" on #content, test childrenCount > 2) Add aria-hidden, test childrenCount > 3) Change to aria-hidden=true, test childrenCount > 4) Change to aria-hidden=false, test childrenCount > > That way all cases of [type=hidden] are covered. > > > LayoutTests/accessibility/input-type-hidden-in-aria-hidden-false.html:23 > > + document.getElementById("content").style.visibility = "hidden"; > > Forgot this? Thanks! I'll make these changes |