Bug 138100

Summary: REGRESSION(r155906): Page content disappears on Tuaw article after loading
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: CSSAssignee: Bem Jones-Bey <bjonesbe>
Status: RESOLVED FIXED    
Severity: Normal CC: bjonesbe, commit-queue, esprehn+autocc, glenn, hyatt, kondapallykalyan, simon.fraser, zalan
Priority: P1 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
More minimal test case
none
Standalone testcase
none
Patch
simon.fraser: review+, simon.fraser: commit-queue-
Updated Patch none

Description Simon Fraser (smfr) 2014-10-27 13:29:46 PDT
When loading http://www.tuaw.com/2014/10/21/whats-apple-doing-with-the-ipad-mini-3/?ncid=rss_truncated in Safari 7.1 on Mavericks, after the page finishes loading, the main story disappears.

Resizing the window does not bring it back, but opening the inspector and toggling some style on a hidden element does cause it to render correctly.
Comment 1 Simon Fraser (smfr) 2014-10-27 13:30:27 PDT
rdar://problem/18775249
Comment 2 Bem Jones-Bey 2014-11-20 10:45:50 PST
Created attachment 241960 [details]
More minimal test case

I spent some time yesterday looking into this and minimizing the test case. This isn't completely minimized, but it's a lot simpler than the full tuaw article. I probably won't have time to look at this for a little bit, so if someone else has time to look at it in the meantime, hopefully this will help.
Comment 3 Simon Fraser (smfr) 2014-11-20 11:25:43 PST
It looks like the render tree is OK, but the RenderLayer tree is missing some layers.
Comment 4 Simon Fraser (smfr) 2014-11-20 11:55:26 PST
Created attachment 241966 [details]
Standalone testcase
Comment 5 Simon Fraser (smfr) 2014-12-03 13:26:01 PST
Bem, did the testcase help?
Comment 6 Bem Jones-Bey 2014-12-03 15:14:10 PST
(In reply to comment #5)
> Bem, did the testcase help?

I was out all last week, and I haven't had a chance to look at it yet. It's on my list, though.
Comment 7 Simon Fraser (smfr) 2014-12-08 11:37:15 PST
Ping?
Comment 8 Bem Jones-Bey 2014-12-08 15:37:14 PST
(In reply to comment #7)
> Ping?

Unfortunately, there's been a sickness in my family, and I haven't gotten any work done in the past few days. I should be back at it as usual tomorrow.

One thing that would help: I seem to remember you mentioning that you had tracked this issue down to a particular commit. Can you remind me of which one that is? I had thought it was in the bug, but it's not.
Comment 9 zalan 2014-12-08 15:42:59 PST
(In reply to comment #8)
> (In reply to comment #7)
> > Ping?
> 
> Unfortunately, there's been a sickness in my family, and I haven't gotten
> any work done in the past few days. I should be back at it as usual tomorrow.
> 
> One thing that would help: I seem to remember you mentioning that you had
> tracked this issue down to a particular commit. Can you remind me of which
> one that is? I had thought it was in the bug, but it's not.
r155906. (it's in the title)
Comment 10 Simon Fraser (smfr) 2014-12-08 16:46:17 PST
It's in the title :)
Comment 11 Bem Jones-Bey 2014-12-09 14:01:09 PST
So, I have a fix, but I am having trouble creating a test for it. The render tree is always correct, and the test case renders fine both as a reftest and a pixel test. Anyone have any suggestions for how I might be able to write a test for this?
Comment 12 Bem Jones-Bey 2014-12-09 15:23:22 PST
Created attachment 242970 [details]
Patch
Comment 13 Simon Fraser (smfr) 2014-12-09 15:34:03 PST
Comment on attachment 242970 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242970&action=review

> Source/WebCore/ChangeLog:12
> +        it can change if the float's renderer has a self painting layer. So in

can change _whether_ the
Comment 14 Bem Jones-Bey 2014-12-09 16:14:24 PST
Created attachment 242974 [details]
Updated Patch
Comment 15 WebKit Commit Bot 2014-12-09 16:56:35 PST
Comment on attachment 242974 [details]
Updated Patch

Clearing flags on attachment: 242974

Committed r177049: <http://trac.webkit.org/changeset/177049>
Comment 16 WebKit Commit Bot 2014-12-09 16:56:40 PST
All reviewed patches have been landed.  Closing bug.