Bug 138080

Summary:

Replace Element::didAffectSelector() by setNeedsStyleRecalc()

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Benjamin Poulain 2014-10-25 22:31:54 PDT

Replace Element::didAffectSelector() by setNeedsStyleRecalc()

Comment 1 Benjamin Poulain 2014-10-25 22:35:44 PDT

Created attachment 240462 [details]
Patch

Comment 2 Andreas Kling 2014-10-26 12:52:10 PDT

Comment on attachment 240462 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240462&action=review

r=me

> Source/WebCore/ChangeLog:9
> +        Element::didAffectSelector() was probably an optimization at some point,
> +        with the current code is does nothing more than setNeedsStyleRecalc().

A+ assessment, would believe again.

Comment 3 Benjamin Poulain 2014-10-26 21:20:19 PDT

Comment on attachment 240462 [details]
Patch

Clearing flags on attachment: 240462

Committed r175212: <http://trac.webkit.org/changeset/175212>

Comment 4 Benjamin Poulain 2014-10-26 21:20:22 PDT

All reviewed patches have been landed.  Closing bug.