Bug 138063

Summary: _actionMenuItemsForHitTestResult should also take a type indicating what the menu was built for
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, conrad_shultz, mitz, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch v2 mitz: review+

Beth Dakin
Reported 2014-10-24 16:25:07 PDT
_actionMenuItemsForHitTestResult should also take a type indicating what the menu was built for since HitTestResults that are both images and links could go either way.
Attachments
Patch (11.94 KB, patch)
2014-10-24 16:28 PDT, Beth Dakin 		no flags
DetailsFormatted DiffDiff
Patch v2 (11.94 KB, patch)
2014-10-24 16:40 PDT, Beth Dakin 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2014-10-24 16:28:46 PDT
Created attachment 240445 [details] Patch
Beth Dakin
Comment 2 2014-10-24 16:40:28 PDT
Created attachment 240446 [details] Patch v2 Oopsie, that wasn't quite right. This one should do it.
mitz
Comment 3 2014-10-24 16:44:31 PDT
Comment on attachment 240446 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=240446&action=review > Source/WebKit2/Shared/API/c/WKActionMenuTypes.h:40 > +typedef uint32_t WKActionMenuType; Can you give this an underscore prefix in case we ever want to use this name for something in the modern API? > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:68 > + Extra newline.
Beth Dakin
Comment 4 2014-10-24 16:52:13 PDT
Thanks Dan! http://trac.webkit.org/changeset/175193
Note You need to log in before you can comment on or make changes to this bug.