Bug 138062

Summary: Share sheet doesn't attach to the window
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, conrad_shultz, mitz, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch bdakin: review+

Tim Horton
Reported 2014-10-24 15:58:11 PDT
Share sheet doesn't attach to the window
Attachments
Patch (3.45 KB, patch)
2014-10-24 15:58 PDT, Tim Horton 		bdakin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-10-24 15:58:35 PDT
Created attachment 240444 [details] Patch
Tim Horton
Comment 2 2014-10-24 16:00:36 PDT
<rdar://problem/18767397>
Conrad Shultz
Comment 3 2014-10-24 16:07:24 PDT
Comment on attachment 240444 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240444&action=review > Source/WebKit2/UIProcess/mac/WKActionMenuController.h:46 > +@interface WKActionMenuController : NSObject <NSSharingServiceDelegate, NSSharingServicePickerDelegate> { Can this be done in a class extension instead?
Tim Horton
Comment 4 2014-10-24 16:15:26 PDT
(In reply to comment #3) > Comment on attachment 240444 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=240444&action=review > > > Source/WebKit2/UIProcess/mac/WKActionMenuController.h:46 > > +@interface WKActionMenuController : NSObject <NSSharingServiceDelegate, NSSharingServicePickerDelegate> { > > Can this be done in a class extension instead? Oops, I missed this before landing. Maybe I can! I'll have to see. http://trac.webkit.org/changeset/175190
Note You need to log in before you can comment on or make changes to this bug.