Bug 138062

Summary: Share sheet doesn't attach to the window
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, conrad_shultz, mitz, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch bdakin: review+

Description Tim Horton 2014-10-24 15:58:11 PDT 
Share sheet doesn't attach to the window
Comment 1 Tim Horton 2014-10-24 15:58:35 PDT 
Created attachment 240444 [details]
Patch
Comment 2 Tim Horton 2014-10-24 16:00:36 PDT 
<rdar://problem/18767397>
Comment 3 Conrad Shultz 2014-10-24 16:07:24 PDT 
Comment on attachment 240444 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240444&action=review

> Source/WebKit2/UIProcess/mac/WKActionMenuController.h:46
> +@interface WKActionMenuController : NSObject <NSSharingServiceDelegate, NSSharingServicePickerDelegate> {

Can this be done in a class extension instead?
Comment 4 Tim Horton 2014-10-24 16:15:26 PDT 
(In reply to comment #3)
> Comment on attachment 240444 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240444&action=review
> 
> > Source/WebKit2/UIProcess/mac/WKActionMenuController.h:46
> > +@interface WKActionMenuController : NSObject <NSSharingServiceDelegate, NSSharingServicePickerDelegate> {
> 
> Can this be done in a class extension instead?

Oops, I missed this before landing.

Maybe I can! I'll have to see.

http://trac.webkit.org/changeset/175190