Bug 138062 - Share sheet doesn't attach to the window
Summary: Share sheet doesn't attach to the window
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-24 15:58 PDT by Tim Horton
Modified: 2014-10-24 16:15 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.45 KB, patch)
2014-10-24 15:58 PDT, Tim Horton 		bdakin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-10-24 15:58:11 PDT 
Share sheet doesn't attach to the window
Comment 1 Tim Horton 2014-10-24 15:58:35 PDT 
Created attachment 240444 [details]
Patch
Comment 2 Tim Horton 2014-10-24 16:00:36 PDT 
<rdar://problem/18767397>
Comment 3 Conrad Shultz 2014-10-24 16:07:24 PDT 
Comment on attachment 240444 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240444&action=review

> Source/WebKit2/UIProcess/mac/WKActionMenuController.h:46
> +@interface WKActionMenuController : NSObject <NSSharingServiceDelegate, NSSharingServicePickerDelegate> {

Can this be done in a class extension instead?
Comment 4 Tim Horton 2014-10-24 16:15:26 PDT 
(In reply to comment #3)
> Comment on attachment 240444 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240444&action=review
> 
> > Source/WebKit2/UIProcess/mac/WKActionMenuController.h:46
> > +@interface WKActionMenuController : NSObject <NSSharingServiceDelegate, NSSharingServicePickerDelegate> {
> 
> Can this be done in a class extension instead?

Oops, I missed this before landing.

Maybe I can! I'll have to see.

http://trac.webkit.org/changeset/175190