Bug 138059

Summary: Very large images crash in action menu code
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, conrad_shultz, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Beth Dakin
Reported 2014-10-24 15:18:20 PDT
Very large images crash in action menu code. rdar://problem/18767859
Attachments
Patch (3.54 KB, patch)
2014-10-24 15:21 PDT, Beth Dakin 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2014-10-24 15:21:26 PDT
Created attachment 240440 [details] Patch
Tim Horton
Comment 2 2014-10-24 15:24:26 PDT
Comment on attachment 240440 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240440&action=review > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:186 > + RefPtr<ShareableBitmap> bitmap = _hitTestResult.image; could do this check in _defaultMenuItems instead so we can do smart fallback there and not worry about these things here.
Beth Dakin
Comment 3 2014-10-24 15:28:17 PDT
http://trac.webkit.org/changeset/175187
Note You need to log in before you can comment on or make changes to this bug.