Bug 138059

Summary:

Very large images crash in action menu code

Product:

WebKit

Reporter:

Beth Dakin <bdakin>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, conrad_shultz, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+

Description Beth Dakin 2014-10-24 15:18:20 PDT

Very large images crash in action menu code.

rdar://problem/18767859

Comment 1 Beth Dakin 2014-10-24 15:21:26 PDT

Created attachment 240440 [details]
Patch

Comment 2 Tim Horton 2014-10-24 15:24:26 PDT

Comment on attachment 240440 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240440&action=review

> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:186
> +    RefPtr<ShareableBitmap> bitmap = _hitTestResult.image;

could do this check in _defaultMenuItems instead so we can do smart fallback there and not worry about these things here.

Comment 3 Beth Dakin 2014-10-24 15:28:17 PDT

http://trac.webkit.org/changeset/175187