Summary: | Simplified IndexingType's hasAnyArrayStorage() | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Mark Lam
2014-10-24 11:51:42 PDT
Created attachment 240421 [details]
the patch.
Comment on attachment 240421 [details] the patch. View in context: https://bugs.webkit.org/attachment.cgi?id=240421&action=review r=me Fix the comment issues. > Source/JavaScriptCore/runtime/IndexingType.h:39 > + struct IndextingType { Spelling of IndextingType > Source/JavaScriptCore/runtime/IndexingType.h:42 > + uint8_t maHaveIndexedShapes:1; // bit 5 Should this be mayHaveIndexedShapes? Thanks. I also found 2 more errors in the comments (should not have tabs, and "mayHaveIndexedAccessors"instead of "mayHaveIndexedShape"). Fixed comments, and landed in r175172: <http://trac.webkit.org/r175172>. |