Summary: | Avoid unnecessary NSURLRequest copies in ResourceRequest::doUpdatePlatformRequest() / doUpdatePlatformHTTPBody() | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
Component: | Page Loading | Assignee: | Chris Dumez <cdumez> | ||||
Status: | REOPENED --- | ||||||
Severity: | Normal | CC: | ap, benjamin, commit-queue, darin | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 146470 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Chris Dumez
2014-10-24 11:06:00 PDT
Created attachment 240418 [details]
Patch
Comment on attachment 240418 [details] Patch Clearing flags on attachment: 240418 Committed r175171: <http://trac.webkit.org/changeset/175171> All reviewed patches have been landed. Closing bug. This got rolled out. Do we know what the problem was? Was it that the mutable NSURLRequest wasn't expected to be changed? (In reply to comment #4) > This got rolled out. Do we know what the problem was? Was it that the > mutable NSURLRequest wasn't expected to be changed? I haven't had time to investigate yet. My priority was to safely and quickly fix the crash at this point and a simple roll out seemed like the right thing to do. I'll take another look when I get some spare cycles. Reopening since it was rolled out. |