Bug 138044

Summary: Add optimized fullscreen mode.
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: WebKit2Assignee: Jeremy Jones <jeremyj-wk>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, buildbot, commit-queue, eric.carlson, ossy, rniwa, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: Unspecified   
Bug Depends on: 138320    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
jer.noble: review+
Patch for landing. none

Description Jeremy Jones 2014-10-24 04:37:06 PDT 
Add optimized fullscreen mode.
Comment 1 Simon Fraser (smfr) 2014-10-24 11:07:21 PDT 
What does "optimized fullscreen" mean?
Comment 2 Jeremy Jones 2014-10-27 12:06:13 PDT 
rdar://problem/18762317
Comment 3 Jeremy Jones 2014-10-27 12:26:02 PDT 
Created attachment 240492 [details]
Patch
Comment 4 WebKit Commit Bot 2014-10-27 12:28:43 PDT 
Attachment 240492 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:873:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:956:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Jeremy Jones 2014-10-27 17:49:06 PDT 
Created attachment 240516 [details]
Patch
Comment 6 WebKit Commit Bot 2014-10-27 17:50:42 PDT 
Attachment 240516 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:873:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:888:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:955:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 3 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Jer Noble 2014-10-28 10:45:34 PDT 
Comment on attachment 240516 [details]
Patch

r=me, but this still needs to be signed off by a WK2 reviewer.
Comment 8 Anders Carlsson 2014-10-28 10:49:19 PDT 
WK2 parts look fine.
Comment 9 Jeremy Jones 2014-10-28 13:07:23 PDT 
Created attachment 240565 [details]
Patch for landing.
Comment 10 WebKit Commit Bot 2014-10-28 13:09:01 PDT 
Attachment 240565 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:868:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:883:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:950:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 3 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 WebKit Commit Bot 2014-10-28 16:14:40 PDT 
Comment on attachment 240565 [details]
Patch for landing.

Clearing flags on attachment: 240565

Committed r175279: <http://trac.webkit.org/changeset/175279>