Bug 138044

Summary: Add optimized fullscreen mode.
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: WebKit2Assignee: Jeremy Jones <jeremyj-wk>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, buildbot, commit-queue, eric.carlson, ossy, rniwa, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: Unspecified   
Bug Depends on: 138320    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
jer.noble: review+
Patch for landing. none

Jeremy Jones
Reported 2014-10-24 04:37:06 PDT
Add optimized fullscreen mode.
Attachments
Patch (41.57 KB, patch)
2014-10-27 12:26 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Patch (41.62 KB, patch)
2014-10-27 17:49 PDT, Jeremy Jones 		jer.noble: review+
DetailsFormatted DiffDiff
Patch for landing. (41.42 KB, patch)
2014-10-28 13:07 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2014-10-24 11:07:21 PDT
What does "optimized fullscreen" mean?
Jeremy Jones
Comment 2 2014-10-27 12:06:13 PDT
rdar://problem/18762317
Jeremy Jones
Comment 3 2014-10-27 12:26:02 PDT
Created attachment 240492 [details] Patch
WebKit Commit Bot
Comment 4 2014-10-27 12:28:43 PDT
Attachment 240492 [details] did not pass style-queue: ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:873: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:956: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jeremy Jones
Comment 5 2014-10-27 17:49:06 PDT
Created attachment 240516 [details] Patch
WebKit Commit Bot
Comment 6 2014-10-27 17:50:42 PDT
Attachment 240516 [details] did not pass style-queue: ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:873: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:888: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:955: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 3 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jer Noble
Comment 7 2014-10-28 10:45:34 PDT
Comment on attachment 240516 [details] Patch r=me, but this still needs to be signed off by a WK2 reviewer.
Anders Carlsson
Comment 8 2014-10-28 10:49:19 PDT
WK2 parts look fine.
Jeremy Jones
Comment 9 2014-10-28 13:07:23 PDT
Created attachment 240565 [details] Patch for landing.
WebKit Commit Bot
Comment 10 2014-10-28 13:09:01 PDT
Attachment 240565 [details] did not pass style-queue: ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:868: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:883: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:950: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 3 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 11 2014-10-28 16:14:40 PDT
Comment on attachment 240565 [details] Patch for landing. Clearing flags on attachment: 240565 Committed r175279: <http://trac.webkit.org/changeset/175279>
Note You need to log in before you can comment on or make changes to this bug.