Bug 138031 – [iOS WK2] If a page has the exact same VisibleContentRect as the page before, its VisibleContentRectUpdate can be ignored

• Component: New Bugs
• Status: RESOLVED FIXED

[Benjamin Poulain]

[iOS WK2] If a page has the exact same VisibleContentRect as the page before, its VisibleContentRectUpdate can be ignored

[Benjamin Poulain]

Created attachment 240379 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 240379 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240379&action=review

Mumble testing mumble.

> Source/WebKit2/UIProcess/WebPageProxy.cpp:2624
> +        m_firstLayerTreeTransactionIdAfterDidCommitLoadForMainFrame = downcast<RemoteLayerTreeDrawingAreaProxy>(*drawingArea()).nextLayerTreeTransactionID();

It makes me slightly uneasy just fetching nextLayerTreeTransactionID(). How about changing it to m_layerTreeTransactionIdAtDidCommitLoad and just using the ID of the last received transaction? Then lower down you would have:

layerTreeTransaction.transactionID() > m_layerTreeTransactionIdAtDidCommitLoad

> Source/WebKit2/UIProcess/WebPageProxy.h:1361
> +    bool m_hasReceivedLayerTreeTransactionAfterDidCommitLoadForMainFrame;
> +    uint64_t m_firstLayerTreeTransactionIdAfterDidCommitLoadForMainFrame;

These names are really long. I think you could drop the "ForMainFrame".

[Benjamin Poulain]

Committed r175153: <http://trac.webkit.org/changeset/175153>