Bug 138030

Summary:

[Mac] Optimize URL::createCFURL() for the common case

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Page Loading

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

ap, barraclough, benjamin, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Chris Dumez 2014-10-23 16:32:47 PDT

Optimize URL::createCFURL() for the common case by adding a fast path for when the URL String is already 8-bit (common case).
When the string is 8-bit, we don't need to copy the bytes in a temporary buffer and we can construct the CFURLRef directly from it.
This makes URL::createCFURL() ~34% faster on my machine.

Comment 1 Chris Dumez 2014-10-23 16:39:48 PDT

Created attachment 240376 [details]
Patch

Comment 2 WebKit Commit Bot 2014-10-23 18:29:49 PDT

Comment on attachment 240376 [details]
Patch

Clearing flags on attachment: 240376

Committed r175154: <http://trac.webkit.org/changeset/175154>

Comment 3 WebKit Commit Bot 2014-10-23 18:29:54 PDT

All reviewed patches have been landed.  Closing bug.