Bug 138030

Summary: [Mac] Optimize URL::createCFURL() for the common case
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Page LoadingAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Enhancement CC: ap, barraclough, benjamin, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2014-10-23 16:32:47 PDT
Optimize URL::createCFURL() for the common case by adding a fast path for when the URL String is already 8-bit (common case). When the string is 8-bit, we don't need to copy the bytes in a temporary buffer and we can construct the CFURLRef directly from it. This makes URL::createCFURL() ~34% faster on my machine.
Attachments
Patch (1.86 KB, patch)
2014-10-23 16:39 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-10-23 16:39:48 PDT
Created attachment 240376 [details] Patch
WebKit Commit Bot
Comment 2 2014-10-23 18:29:49 PDT
Comment on attachment 240376 [details] Patch Clearing flags on attachment: 240376 Committed r175154: <http://trac.webkit.org/changeset/175154>
WebKit Commit Bot
Comment 3 2014-10-23 18:29:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.