Bug 138027

Summary: Add some SPI headers for NSExtension and NSSharingService{Picker}
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, beidson, commit-queue, esprehn+autocc, glenn, kondapallykalyan, mitz, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Tim Horton
Reported 2014-10-23 15:39:48 PDT
Add some SPI headers for NSExtension and NSSharingService{Picker}
Attachments
Patch (25.96 KB, patch)
2014-10-23 15:40 PDT, Tim Horton 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-10-23 15:40:25 PDT
Created attachment 240372 [details] Patch
WebKit Commit Bot
Comment 2 2014-10-23 15:43:11 PDT
Attachment 240372 [details] did not pass style-queue: ERROR: Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: Source/WebCore/platform/spi/mac/NSSharingServiceSPI.h:40: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit/mac/Misc/WebSharingServicePickerController.h:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/mac/ChangeLog:3: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 5 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 3 2014-10-23 16:01:14 PDT
https://trac.webkit.org/changeset/175147
Radar WebKit Bug Importer
Comment 4 2014-10-23 16:02:23 PDT
<rdar://problem/18757166>
Note You need to log in before you can comment on or make changes to this bug.