Bug 138019

Summary: Clean up virtual functions in dom/
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, darin, esprehn+autocc, kangil.han, kling, koivisto, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2014-10-23 13:51:46 PDT
Clean up virtual functions in rendering/ by: - Making virtual functions final when possible - Making classes final when possible - Using 'override' when appropriate - Explicitly marking functions / destructors as virtual when they are inherently virtual - Making isXXX() virtual functions private on XXX classes to avoid unnecessary type checks - Dropping final for virtual functions in classes already marked as final
Attachments
Patch (37.50 KB, patch)
2014-10-23 13:55 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (38.63 KB, patch)
2014-10-23 15:06 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-10-23 13:55:00 PDT
Created attachment 240366 [details] Patch
WebKit Commit Bot
Comment 2 2014-10-23 13:56:33 PDT
Attachment 240366 [details] did not pass style-queue: ERROR: Source/WebCore/dom/MutationEvent.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 40 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 3 2014-10-23 15:06:10 PDT
Created attachment 240371 [details] Patch
WebKit Commit Bot
Comment 4 2014-10-23 15:07:23 PDT
Attachment 240371 [details] did not pass style-queue: ERROR: Source/WebCore/dom/MutationEvent.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 40 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 5 2014-10-23 16:25:59 PDT
Comment on attachment 240371 [details] Patch Clearing flags on attachment: 240371 Committed r175148: <http://trac.webkit.org/changeset/175148>
WebKit Commit Bot
Comment 6 2014-10-23 16:26:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.