| Summary: | Clean up virtual functions in dom/ | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
| Component: | DOM | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, commit-queue, darin, esprehn+autocc, kangil.han, kling, koivisto, WebkitBugTracker | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 240366 [details]
Patch
Attachment 240366 [details] did not pass style-queue:
ERROR: Source/WebCore/dom/MutationEvent.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 40 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 240371 [details]
Patch
Attachment 240371 [details] did not pass style-queue:
ERROR: Source/WebCore/dom/MutationEvent.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 40 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 240371 [details] Patch Clearing flags on attachment: 240371 Committed r175148: <http://trac.webkit.org/changeset/175148> All reviewed patches have been landed. Closing bug. |
Clean up virtual functions in rendering/ by: - Making virtual functions final when possible - Making classes final when possible - Using 'override' when appropriate - Explicitly marking functions / destructors as virtual when they are inherently virtual - Making isXXX() virtual functions private on XXX classes to avoid unnecessary type checks - Dropping final for virtual functions in classes already marked as final