Bug 137997

Summary:

Refactoring to simplify some code in DatePrototype.cpp

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
the patch.	none

Mark Lam

Reported 2014-10-22 18:51:53 PDT

A bunch of functions in DatePrototype.cpp have the pattern of loading a constant into a local variable only to pass it to a callee function immediately after. There is no other use for that variable. This adds additional verbosity with no added benefit. Will fix.

Attachments
the patch. (5.43 KB, patch) 2014-10-22 18:56 PDT, Mark Lam	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Mark Lam

Comment 1 2014-10-22 18:56:18 PDT

Created attachment 240319 [details] the patch.

Filip Pizlo

Comment 2 2014-10-22 19:01:16 PDT

Comment on attachment 240319 [details] the patch. Nice!

WebKit Commit Bot

Comment 3 2014-10-22 19:39:13 PDT

Comment on attachment 240319 [details] the patch. Clearing flags on attachment: 240319 Committed r175080: <http://trac.webkit.org/changeset/175080>

WebKit Commit Bot

Comment 4 2014-10-22 19:39:15 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.