Bug 137983

Summary: [Mac] don't update caption user style sheet during parsing
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, glenn, jer.noble, philipj, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch.
none
Updated patch none

Eric Carlson
Reported 2014-10-22 15:07:30 PDT
CaptionUserPreferencesMediaAF::setInterestedInCaptionPreferenceChanges is called whenever a audio or video element is created. It calls updateCaptionStyleSheetOveride which generates and inserts a user style sheet. This is an expensive operation and it can happen during document parsing/creation, so it should be done after a brief delay.
Attachments
Proposed patch. (1.85 KB, patch)
2014-10-23 10:53 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Updated patch (3.74 KB, patch)
2014-10-23 11:32 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2014-10-23 10:53:52 PDT
Created attachment 240351 [details] Proposed patch.
Eric Carlson
Comment 2 2014-10-23 11:32:23 PDT
Created attachment 240355 [details] Updated patch
WebKit Commit Bot
Comment 3 2014-10-23 13:27:25 PDT
Comment on attachment 240355 [details] Updated patch Clearing flags on attachment: 240355 Committed r175139: <http://trac.webkit.org/changeset/175139>
WebKit Commit Bot
Comment 4 2014-10-23 13:27:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.