Bug 137977

Summary:

commitqueuetask should include more tests to ensure that the behavior of PatchAnalysisTask._test_patch() is well defined

Product:

WebKit

Reporter:

Jake Nielsen <jake.nielsen.webkit>

Component:

Tools / Tests

Assignee:

Jake Nielsen <jake.nielsen.webkit>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, glenn

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Just for viewing purposes	jake.nielsen.webkit: review-, jake.nielsen.webkit: commit-queue-
Adds FIXMEs to tests, and sets the test expectations to agree with current behavior.	none

Description Jake Nielsen 2014-10-22 12:20:37 PDT

This may also include adding some more convenient mocking/testing infrastructure to make it easier to write new tests.

Comment 1 Jake Nielsen 2014-10-22 14:42:10 PDT

Created attachment 240297 [details]
Just for viewing purposes

I just want to discuss some of the added test cases.

Comment 2 Jake Nielsen 2014-10-22 15:44:18 PDT

Created attachment 240300 [details]
Adds FIXMEs to tests, and sets the test expectations to agree with current behavior.

Comment 3 WebKit Commit Bot 2014-10-22 16:27:26 PDT

Comment on attachment 240300 [details]
Adds FIXMEs to tests, and sets the test expectations to agree with current behavior.

Clearing flags on attachment: 240300

Committed r175073: <http://trac.webkit.org/changeset/175073>

Comment 4 WebKit Commit Bot 2014-10-22 16:27:30 PDT

All reviewed patches have been landed.  Closing bug.