| Summary: | [GTK] RenderThemeGtk::mediaControlsScript() is not defined when VIDEO is disabled | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Milan Crha <mcrha> | ||||||
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cgarcia, commit-queue, esprehn+autocc, glenn, kondapallykalyan | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 137488 | ||||||||
| Attachments: |
|
||||||||
|
Description
Milan Crha
2014-10-22 11:16:26 PDT
Created attachment 240281 [details]
proposed wk patch
Comment on attachment 240281 [details] proposed wk patch View in context: https://bugs.webkit.org/attachment.cgi?id=240281&action=review > Source/WebCore/ChangeLog:5 > + RenderThemeGtk::mediaControlsScript() is not defined when > + VIDEO is disabled. > + <https://webkit.org/b/137970>. Do not split the bug title line, are you using prepareChangelog script to generate the changelog entries? Yes, I use the script, I only thought the line it too long, at least with compare of the other changelog entries, thus I wrapped it. I will resend the patch with unwrapped line. Created attachment 240334 [details]
proposed wk patch with no line wrap in the ChangeLog
Comment on attachment 240334 [details] proposed wk patch with no line wrap in the ChangeLog Clearing flags on attachment: 240334 Committed r175095: <http://trac.webkit.org/changeset/175095> All reviewed patches have been landed. Closing bug. |