Bug 137957

Summary: [TexMap] Clean up virtual method declarations in GraphicsLayerTextureMapper
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, commit-queue, gyuyoung.kim, kondapallykalyan, luiz, mrobinson, noam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Zan Dobersek
Reported 2014-10-22 06:51:37 PDT
[TexMap] Clean up virtual method declarations in GraphicsLayerTextureMapper
Attachments
Patch (10.25 KB, patch)
2014-10-22 06:58 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2014-10-22 06:58:17 PDT
Created attachment 240271 [details] Patch
Martin Robinson
Comment 2 2014-10-22 07:51:03 PDT
Comment on attachment 240271 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240271&action=review > Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h:35 > +class GraphicsLayerTextureMapper final : public GraphicsLayer, TextureMapperPlatformLayer::Client { Why is TextureMapperPlatformLayer::Client no longer public here?
Zan Dobersek
Comment 3 2014-10-22 08:41:43 PDT
Comment on attachment 240271 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240271&action=review >> Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h:35 >> +class GraphicsLayerTextureMapper final : public GraphicsLayer, TextureMapperPlatformLayer::Client { > > Why is TextureMapperPlatformLayer::Client no longer public here? There's no need for that -- there are no member variables that we would need access to (or at all) in that class, and the overriding methods in GraphicsLayerTextureMapper are also private.
Martin Robinson
Comment 4 2014-10-22 08:44:03 PDT
(In reply to comment #3) > Comment on attachment 240271 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=240271&action=review > > >> Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h:35 > >> +class GraphicsLayerTextureMapper final : public GraphicsLayer, TextureMapperPlatformLayer::Client { > > > > Why is TextureMapperPlatformLayer::Client no longer public here? > > There's no need for that -- there are no member variables that we would need > access to (or at all) in that class, and the overriding methods in > GraphicsLayerTextureMapper are also private. Is it common in WebKit to use private inheritance?
Zan Dobersek
Comment 5 2014-10-22 09:03:40 PDT
Comment on attachment 240271 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240271&action=review >>>> Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h:35 >>>> +class GraphicsLayerTextureMapper final : public GraphicsLayer, TextureMapperPlatformLayer::Client { >>> >>> Why is TextureMapperPlatformLayer::Client no longer public here? >> >> There's no need for that -- there are no member variables that we would need access to (or at all) in that class, and the overriding methods in GraphicsLayerTextureMapper are also private. > > Is it common in WebKit to use private inheritance? I count 8 cases in WebCore, 14 in WebKit2. Not the most common pattern, but not shunned either.
Zan Dobersek
Comment 6 2014-10-23 04:17:36 PDT
Comment on attachment 240271 [details] Patch Clearing flags on attachment: 240271 Committed r175116: <http://trac.webkit.org/changeset/175116>
Zan Dobersek
Comment 7 2014-10-23 04:17:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.