Bug 137949

Summary: [EFL] build-webkit should try harder to avoid re-running cmake
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, dbates, gyuyoung.kim, mrobinson, ossy, ryuan.choi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 137818    
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2014-10-22 04:10:57 PDT
GTK already re-run cmake only if it is necessary: http://trac.webkit.org/changeset/162545 ( bug127073 ) I think the configuration change detection in shouldRemoveCMakeCache() is safe, and it seems it has worked well since half years for GTK. So I propose to use this mechanism for EFL port too. It would make incremantal build faster for developers and buildbots too.
Attachments
Patch (1.85 KB, patch)
2014-10-22 04:19 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2014-10-22 04:19:41 PDT
Created attachment 240262 [details] Patch
Csaba Osztrogonác
Comment 2 2014-10-22 04:25:54 PDT
This change decreased the incremental build time from 36 seconds to 8 seconds on my desktop machine if I didn't touch any files.
WebKit Commit Bot
Comment 3 2014-10-29 03:45:24 PDT
Comment on attachment 240262 [details] Patch Clearing flags on attachment: 240262 Committed r175327: <http://trac.webkit.org/changeset/175327>
WebKit Commit Bot
Comment 4 2014-10-29 03:45:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.