Bug 137934

Summary: import-w3c-tests should use re.escape() wherever it's handling file paths
Product: WebKit Reporter: Rebecca Hauck <rhauck>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, glenn
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Rebecca Hauck
Reported 2014-10-21 15:08:10 PDT
test_converter.py does some path conversions where it uses re.sub(). Since filepaths can have regex characters in them, they should all be escaped.
Attachments
Patch (2.45 KB, patch)
2014-10-22 16:08 PDT, Rebecca Hauck 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rebecca Hauck
Comment 1 2014-10-22 16:08:49 PDT
Created attachment 240301 [details] Patch
Bem Jones-Bey
Comment 2 2014-10-28 09:37:50 PDT
Comment on attachment 240301 [details] Patch r=me
WebKit Commit Bot
Comment 3 2014-10-28 10:52:28 PDT
Comment on attachment 240301 [details] Patch Clearing flags on attachment: 240301 Committed r175257: <http://trac.webkit.org/changeset/175257>
WebKit Commit Bot
Comment 4 2014-10-28 10:52:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.