Bug 137934

Summary:

import-w3c-tests should use re.escape() wherever it's handling file paths

Product:

WebKit

Reporter:

Rebecca Hauck <rhauck>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, glenn

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Rebecca Hauck 2014-10-21 15:08:10 PDT

test_converter.py does some path conversions where it uses re.sub().  Since filepaths can have regex characters in them, they should all be escaped.

Comment 1 Rebecca Hauck 2014-10-22 16:08:49 PDT

Created attachment 240301 [details]
Patch

Comment 2 Bem Jones-Bey 2014-10-28 09:37:50 PDT

Comment on attachment 240301 [details]
Patch

r=me

Comment 3 WebKit Commit Bot 2014-10-28 10:52:28 PDT

Comment on attachment 240301 [details]
Patch

Clearing flags on attachment: 240301

Committed r175257: <http://trac.webkit.org/changeset/175257>

Comment 4 WebKit Commit Bot 2014-10-28 10:52:31 PDT

All reviewed patches have been landed.  Closing bug.