Bug 137932

Summary:

[Win] Run DumpRenderTree using native controls, not SafariTheme.dll

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

Tools / Tests

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Bug Depends on:

Bug Blocks:

25592

Attachments:

Description	Flags
Patch	simon.fraser: review+

Description Brent Fulgham 2014-10-21 13:34:10 PDT

It's time to stop using SafariTheme.dll during DumpRenderTree testing. We don't ship software using SafariTheme.dll anymore, so it's silly to use its output as the basis for our rendering health.

Furthermore, with the release of Yosemite, the drawing style used in SafariTheme no longer matches our Mac baselines. Consequently, many tests will begin failing anyway.

Let's seize this opportunity to rebaseline Windows against its native drawing style.

Comment 1 Brent Fulgham 2014-10-21 13:37:43 PDT

Created attachment 240220 [details]
Patch

Comment 2 Brent Fulgham 2014-10-21 14:13:51 PDT

Committed r174998: <http://trac.webkit.org/changeset/174998>

Comment 3 Brent Fulgham 2014-10-21 17:26:49 PDT

Small set of test expectations updated in r175004. <http://trac.webkit.org/changeset/175004>.