Bug 137931

Summary:

Web Inspector: Fix generator importing of protocol type "any", treat as value

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

burg, commit-queue, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2014-10-21 12:40:43 PDT

The generator import of type "any" was using "getAny" which does not exist. Add the boilerplate for a "getValue".

This is currently unused, otherwise we would have gotten compiler warnings. Arguably we could switch to disallow incoming "any" types, but it is supportable, so I just did a quick implementation.

Comment 1 Joseph Pecoraro 2014-10-21 12:42:13 PDT

Created attachment 240216 [details]
[PATCH] Proposed Fix

Comment 2 WebKit Commit Bot 2014-10-21 12:44:51 PDT

This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)

Comment 3 Joseph Pecoraro 2014-10-21 13:52:02 PDT

Created attachment 240221 [details]
[PATCH] Proposed Fix

Comment 4 WebKit Commit Bot 2014-10-22 12:11:17 PDT

Comment on attachment 240221 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 240221

Committed r175059: <http://trac.webkit.org/changeset/175059>

Comment 5 WebKit Commit Bot 2014-10-22 12:11:21 PDT

All reviewed patches have been landed.  Closing bug.